[PATCH] hook: filter out unstable output in tests

Siddharth Agarwal sid at less-broken.com
Thu Mar 10 13:11:25 EST 2016


On 3/10/16 09:44, timeless wrote:
>
> Then why not grep SyntaxError?
>

Because there are a number of other lines in the output from the same 
command that are useful. For the syntax error *specifically*, only the 
fact that it is a syntax error is useful. In fact the first egrep 
filters out the actual traceback. Those lines just didn't get filtered 
out properly.


> On Mar 10, 2016 12:42 PM, "Siddharth Agarwal" <sid at less-broken.com 
> <mailto:sid at less-broken.com>> wrote:
>
>     On 3/10/16 09:40, Pierre-Yves David wrote:
>
>         But isn't that line part of the SyntaxError report ?
>
>
>     Yes, but what the syntax error is is irrelevant -- the test will
>     work no matter what it is. The only relevant information here is
>     that it is a syntax error.
>     _______________________________________________
>     Mercurial-devel mailing list
>     Mercurial-devel at mercurial-scm.org
>     <mailto:Mercurial-devel at mercurial-scm.org>
>     https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>



More information about the Mercurial-devel mailing list