[PATCH 1 of 4 V2] revset: remove useless extpredicate class (API)

FUJIWARA Katsunori foozy at lares.dti.ne.jp
Thu Mar 10 20:21:08 UTC 2016


# HG changeset patch
# User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
# Date 1457637294 -32400
#      Fri Mar 11 04:14:54 2016 +0900
# Node ID 92c3c1d1c603ad1bde49e9c331a5514431dbffb6
# Parent  bbbac228dfe71f641b525b5f352d37fde771f71e
revset: remove useless extpredicate class (API)

Previous patch makes this classes useless by replacing it with
revsetpredicate of registrar.

BTW, extpredicate itself has already been broken by that patch,
because revsetpredicate of registrar doesn't have compatibility with
original predicate (derived from funcregistrar of registrar), in fact.

diff --git a/mercurial/revset.py b/mercurial/revset.py
--- a/mercurial/revset.py
+++ b/mercurial/revset.py
@@ -484,28 +484,6 @@ safesymbols = set()
 
 predicate = registrar.revsetpredicate()
 
-class extpredicate(registrar.delayregistrar):
-    """Decorator to register revset predicate in extensions
-
-    Usage::
-
-        revsetpredicate = revset.extpredicate()
-
-        @revsetpredicate('mypredicate(arg1, arg2[, arg3])')
-        def mypredicatefunc(repo, subset, x):
-            '''Explanation of this revset predicate ....
-            '''
-            pass
-
-        def uisetup(ui):
-            revsetpredicate.setup()
-
-    'revsetpredicate' instance above can be used to decorate multiple
-    functions, and 'setup()' on it registers all such functions at
-    once.
-    """
-    registrar = predicate
-
 @predicate('_destupdate')
 def _destupdate(repo, subset, x):
     # experimental revset for update destination


More information about the Mercurial-devel mailing list