[PATCH 6 of 6] blackbox: trap warnings

Pierre-Yves David pierre-yves.david at ens-lyon.org
Fri Mar 11 08:42:27 EST 2016

On 03/11/2016 01:38 PM, Yuya Nishihara wrote:
> On Wed, 9 Mar 2016 16:56:59 +0000, Pierre-Yves David wrote:
>> On 03/03/2016 04:48 PM, Yuya Nishihara wrote:
>>> On Thu, 3 Mar 2016 08:57:17 -0500, timeless wrote:
>>>> I can put this behind a flag...
>>> A flag won't be necessary because the log is filtered by blackbox.track.
>>> My concern is about the design. I'm not the right person who can tell
>>> the design of the blackbox extension.
>> So what's the plan here?
> I hope the patch 4-6 will be reviewed by someone else who knows the internals
> of the blackbox. This and the previous patch do bulk capturing of warnings,
> which is very different from how ui.log() is currently used.

Timeless, can we get a V2 with these three patch (and initial yuya 
comment fixed) so reboot the review on this ?


Pierre-Yves David

More information about the Mercurial-devel mailing list