[PATCH] chgserver: explicitly set blocking on client socket
yuya at tcha.org
Fri Mar 11 09:10:35 EST 2016
On Thu, 10 Mar 2016 11:25:58 -0800, Sean Farley wrote:
> Yuya Nishihara <yuya at tcha.org> writes:
> > On Wed, 9 Mar 2016 23:58:12 +0000, Jun Wu wrote:
> >> # HG changeset patch
> >> # User Jun Wu <quark at fb.com>
> >> # Date 1457567852 0
> >> # Wed Mar 09 23:57:32 2016 +0000
> >> # Node ID 9a176f60278dd6cd43a8f1a3940d410da2eed731
> >> # Parent b0ed6e1cf51a6c44c5323a35622bea0e35fd0b0d
> >> chgserver: explicitly set blocking on client socket
> >> hgcia.py uses socket.setdefaulttimeout and it will make every new socket object
> >> behave differently. This patch explicitly set client socket to be blocking
> >> without a timeout and makes it possible for chg to pass test-hgcia.t
> > The other socket operation would be suffered by this as well. Perhaps we should
> > fix hgcia.py instead.
> Isn't the cia dead? Should we just drop it?
Yeah, I think we can drop it. It will be a breaking change, but it would be
broken for years.
More information about the Mercurial-devel