[PATCH 7 of 7] templatefilters: document json filter that requires UTF-8 bytes

timeless timeless at gmail.com
Fri Mar 11 09:39:22 EST 2016


So, a reason not to document this filter is if we haven't decided to
formally freeze at our encoding.

I'm not sure if we have, and I don't know if we have enough tests for its
input/output. If we do, then, it's OK to freeze this (if we're confident in
the encoding).
On Mar 11, 2016 8:39 AM, "Yuya Nishihara" <yuya at tcha.org> wrote:

> On Wed, 9 Mar 2016 17:03:30 +0000, Pierre-Yves David wrote:
> > On 03/07/2016 03:11 PM, Pierre-Yves David wrote:
> > > On 02/23/2016 08:35 PM, Augie Fackler wrote:
> > >> On Wed, Feb 24, 2016 at 12:45:32AM +0900, Yuya Nishihara wrote:
> > >>> # HG changeset patch
> > >>> # User Yuya Nishihara <yuya at tcha.org>
> > >>> # Date 1452939833 -32400
> > >>> #      Sat Jan 16 19:23:53 2016 +0900
> > >>> # Node ID 02072a6dba91478d5f12fd52113dce45f0b2a8c3
> > >>> # Parent  484371c3f9c61fd2694aae90b1c650dec203c596
> > >>> templatefilters: document json filter that requires UTF-8 bytes
> > >>
> > >> I've queued patches 1-6, but I have a fuzzy memory that mpm had a
> > >> reason to not document json. Matt?
> > >
> > > Gentle ping.
> >
> > According to timeless, we don't want to document this filter because it
> > would freeze the json format, something we are not ready to. I'm
> > dropping the patch from patchwork.
>
> I don't think this is related to timeless' work. "|json" filter is just
> a general-purpose JSON serializer. But I'm okay to go without a public
> docstring now. Instead, I'll add a comment that says input text should be
> UTF-8.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160311/5734aa14/attachment.html>


More information about the Mercurial-devel mailing list