[PATCH 2 of 5]revsetbenchmarks: use absolute_import and print_function

Augie Fackler raf at durin42.com
Fri Mar 11 10:29:58 EST 2016


On Fri, Mar 11, 2016 at 08:15:15PM +0530, Pulkit Goyal wrote:
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit at gmail.com>
> # Date 1457228303 -19800
> #      Sun Mar 06 07:08:23 2016 +0530
> # Node ID d945babe0ded0a6edef49601ab44b35d7106f8b2
> # Parent  3f76c4e8dd6b18d75fbcabc283dcfae14cc3ac3d
> revsetbenchmarks: use absolute_import and print_function
>

I only got as far as this patch, but so far the changes themselves
look good, and I'd love to help you get them landed in the repo.

[snip]

> @@ -62,11 +69,11 @@
>          output = hg(args, repo=target)
>          return parseoutput(output)
>      except CalledProcessError as exc:
> -        print >> sys.stderr, 'abort: cannot run revset benchmark: %s' % exc.cmd
> +        print('abort: cannot run revset benchmark: %s'%exc.cmd,
> file=sys.stderr)

This ^ right here is a prime example of why you *need* to use 'hg
email' or the pushgate. This patch is fatally whitespace damaged, and
I don't have the time or energy to manually fix up damage caused by a
mailer when there's a known fix readily available to you.

Thanks!


More information about the Mercurial-devel mailing list