[PATCH 5 of 5 postargs] http: support sending hgargs via POST body instead of in GET or headers

Augie Fackler raf at durin42.com
Fri Mar 11 13:06:23 EST 2016

> On Mar 11, 2016, at 13:02, Martin von Zweigbergk <martinvonz at google.com> wrote:
>>>         args = self.req.form.copy()
>>> +        postlen = int(self.req.env.get('HTTP_X_HGARGS_POST', 0))
>>> +        if postlen:
>>> +            return cgi.parse_qs(self.req.read(postlen))
>> Now that data is outside of headers, it feels wasteful to have to URL encode
>> and turn it into a query string like thing. But, it does mean you get to
>> reuse the existing parser, so I guess it isn't too bad. If we ever invent a
>> new, more efficient encoding, we can always invent a new capability to
>> convey that.
> I haven't reviewed the patch yet, but I did suggest
> pushkey.{encode,decode}keys(). Would that be better?

pushkey encoding didn't appear to have enough escaping to be workable for this case.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160311/57eafd2e/attachment.html>

More information about the Mercurial-devel mailing list