[PATCH 6 of 6] rebase: use hg.updatetotally instead of commands.update for efficiency
Sean Farley
sean at farley.io
Fri Mar 11 15:17:00 EST 2016
FUJIWARA Katsunori <foozy at lares.dti.ne.jp> writes:
> # HG changeset patch
> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> # Date 1457724942 -32400
> # Sat Mar 12 04:35:42 2016 +0900
> # Node ID 1b9adcf57c8eba8c3bee50a8de8b11ef0502b28f
> # Parent 4ec341fd8f85ca07dc6f99d82c155e9d559be390
> rebase: use hg.updatetotally instead of commands.update for efficiency
Patch 1 in this series looks fine. I think I like the rest but haven't
fully groked it.
> Using hg.updatetotally() instead of commands.update() is efficient in
> the point of below:
>
> - meaningless checking options in commands.update() is omitted
>
> - calculation of update destination by destutil.destupdate() occurs
> only once
I think that's ok but I'll defer to other reviewers.
More information about the Mercurial-devel
mailing list