[PATCH 1 of 4] zeroconf: remove camelcase in identifiers

Martin von Zweigbergk martinvonz at google.com
Fri Mar 11 18:38:58 EST 2016


On Tue, Mar 8, 2016 at 8:23 PM, timeless <timeless at mozdev.org> wrote:
> # HG changeset patch
> # User timeless <timeless at mozdev.org>
> # Date 1456826265 0
> #      Tue Mar 01 09:57:45 2016 +0000
> # Node ID c80a02c9855bc1335cd817ab4aef72ec48128de7
> # Parent  1c658391b22fb4d98ccfb60c0e57315b55634117
> zeroconf: remove camelcase in identifiers
>
> diff --git a/hgext/zeroconf/Zeroconf.py b/hgext/zeroconf/Zeroconf.py
> --- a/hgext/zeroconf/Zeroconf.py
> +++ b/hgext/zeroconf/Zeroconf.py
> @@ -554,7 +554,7 @@
>          """Reads answers, authorities and additionals section of the packet"""
>          format = '!HHiH'
>          length = struct.calcsize(format)
> -        n = self.numAnswers + self.numAuthorities + self.numAdditionals
> +        n = self.numanswers + self.numAuthorities + self.numadditionals

You missed numAuthorities here. Tests are failing. I'm sending a patch.


More information about the Mercurial-devel mailing list