[PATCH 2 of 2 stable] streamclone: fix error when store files grow while stream cloning

Mads Kiilerich mads at kiilerich.com
Sat Mar 12 21:30:39 EST 2016


On 03/13/2016 02:57 AM, Gregory Szorc wrote:
> Yikes. Good catch.
>
> Series LGTM.
>
> I dare say this one is severe enough to warrant an out-of-cycle 
> release because it can result in serving corrupt clones.

If the problem happens, the clone will fail and be removed again. So it 
would be annoying and can be blocking ... but it is very unlikely it 
could cause real corruption.

> I'm actually somewhat surprised I haven't heard reports of this biting 
> us at Mozilla.

For a while I blamed it at the network. It was only almost-reproducible 
from Korea 4 GB into the clone process on a slow-ish connection. It took 
a lot of attempts before I realized where to look for the problem. I 
guess I have seen it before but mis-diagnosed it ...

/Mads


More information about the Mercurial-devel mailing list