[PATCH v2] push: warn after pushing draft changesets with tags

[Pierre-Yves David]

On 03/12/2016 12:58 AM, Augie Fackler wrote:
> On Fri, Mar 11, 2016 at 11:32:54AM -0800, Sean Farley wrote:
>>
>> Nathan Goldbaum <nathan12343 at gmail.com> writes:
>>
>>> # HG changeset patch
>>> # User Nathan Goldbaum <ngoldbau at illinois.edu>
>>> # Date 1457664319 21600
>>> #      Thu Mar 10 20:45:19 2016 -0600
>>> # Node ID 189ea0e68f3c50c28bbb060c8ef59beef43c8a8d
>>> # Parent  88738948f5d27cebe673ceb655c6161c34efda7d
>>> push: warn after pushing draft changesets with tags
>>
>> I don't know if a warning is going to be enough. After dealing with
>> users over the last year, I'm inclined to think that 'hg tag foo' should
>> just mark the tagged commit as public (or possibly the signed commit).
>
> I have a foggy memory that 'hg tag' was supposed to make the tagged
> revision public. That could be nuts though, as the context I remember
> it in was one of the sprints in Denmark.

This have been mention multiple time but we never really made our mind 
on this. Mistake will taking are not unheard of and it is useful to be 
able to fix them while still local only.

But publishing anything tagged make sense and also help the issue of 
repository that all purely local and grow full draft for ever.

The current motivation for this is that we don't do any rewriting of the 
tag itself when a tagged changeset is rewritten. I wonder to what extend 
this would be easy to introduce.

We could also introduce a special guard to rewrite tagged changeset, the 
same as we are introducing something making harder to do history 
rewriting that create divergence, we could warn about rewritting stuff 
under a tag?

-- 
Pierre-Yves David