[PATCH 3 of 3] extensions: also search for extension in the 'hgext3rd' package

[Ryan McElroy]

On 3/14/2016 1:49 PM, Pierre-Yves David wrote:
>
>
> On 03/14/2016 01:41 PM, timeless wrote:
>> It isn't useful.
>>
>> If we want to have a --debug which lists the search path, that's fine.
>>
>> But for normal "did load" cases, we shouldn't show failures to find
>> extensions in earlier parts of the path.
>>
>> When I run `echo hi` with a PATH of:
>> /usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
>>
>> I don't get:
>>   -bash: /usr/local/bin/echo: command not found
>> hi
>>
>> I just get:
>> hi
>
> That's perpendicular to my patch, there is already such output without 
> it.
>

Doesn't this patch make things strictly worse by adding another place to 
look?

I'd argue for fixing the output problem before making it more of a problem.

Question: If this output already exists, why don't we run into it at FB? 
Is it because we put everything in site-packaged today?

Also, FWIW, I prefer hgextcontrib myself, but I don't care that much.