[PATCH] blackbox: add logreadonlybyuser to restrict permission to log (issue5065)

Ryan McElroy rm at fb.com
Mon Mar 14 10:52:57 EDT 2016


On 3/14/2016 7:59 AM, timeless wrote:
> first, I'd rather start by making the log not world readable.
>
>> +            logreadonlybyuser = self.hasconfig('blackbox', 'logreadonlybyuser')
> second, we typically use configbool(..., ..., False).
> I'm not sure what hasconfig is/does, but I suspect it's the wrong thing.
> e.g --config blackbox.logreadonlybyuser=False
>
> third, I'm not a fan of the name.
>
> and finally, I want to take some time to think about this before we
> take it. (other feedback is welcome)

I agree with most of the points timeless brings up, but my suggestion on 
the way forward would be to make this config be a umask, and call it 
"blackbox.umask" and have it set to 007 by default (though I'm not 
strongly wed to any particular default).

In my opinion, this is much more clear and much more flexible, plus it's 
shorter too. Yay!


More information about the Mercurial-devel mailing list