[PATCH] httpconnection: remove obsolete comment about open()

[Augie Fackler]

> On Mar 14, 2016, at 17:12, Martin von Zweigbergk <martinvonz at google.com> wrote:
> 
> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz at google.com>
> # Date 1457989708 25200
> #      Mon Mar 14 14:08:28 2016 -0700
> # Node ID bb7b8d723e7f4f3c968722f30513e4886ccad104
> # Parent  3bf2892f685f3e240768e2f3b109f4a61a7839d3
> httpconnection: remove obsolete comment about open()

queued, thanks


> When httpsendfile was moved from url.py into httpconnection.py in
> e7525a555a64 (url: use new http support if requested by the user,
> 2011-05-06), the comment about not being able to just call open()
> became obsolete.
> 
> diff -r 3bf2892f685f -r bb7b8d723e7f mercurial/httpconnection.py
> --- a/mercurial/httpconnection.py	Mon Mar 14 12:52:35 2016 +0000
> +++ b/mercurial/httpconnection.py	Mon Mar 14 14:08:28 2016 -0700
> @@ -33,9 +33,6 @@
>     """
> 
>     def __init__(self, ui, *args, **kwargs):
> -        # We can't just "self._data = open(*args, **kwargs)" here because there
> -        # is an "open" function defined in this module that shadows the global
> -        # one
>         self.ui = ui
>         self._data = open(*args, **kwargs)
>         self.seek = self._data.seek
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel