[Bug 5138] New: abstractsubrepo.removefiles is too quiet

[mercurial-bugs at selenic.com]

https://bz.mercurial-scm.org/show_bug.cgi?id=5138

            Bug ID: 5138
           Summary: abstractsubrepo.removefiles is too quiet
           Product: Mercurial
           Version: 3.7.2
          Hardware: PC
                OS: Windows
            Status: UNCONFIRMED
          Severity: feature
          Priority: wish
         Component: Mercurial
          Assignee: bugzilla at selenic.com
          Reporter: timeless at gmail.com
                CC: mercurial-devel at selenic.com

class hgsubrepo(abstractsubrepo):
    def removefiles(self, matcher, prefix, after, force, subrepos):             
        """remove the matched files from the subrepository and the filesystem,  
        possibly by force and/or after the file has been removed from the       
        filesystem.  Return 0 on success, 1 on any warning.                     
        """                                                                     
        return 1                                                                

Stack:
>> removefiles [gitsubrepo] subrepo.py:578
   remove cmdutil.py:2417
   remove commands.py:5924
   check util.py:992
   mqcommand mq.py:3518
   check util.py:992
   closure extensions.py:200
   check util.py:992
   <lambda> dispatch.py:918
   checkargs dispatch.py:1012
   _runcommand dispatch.py:1052
   colorcmd color.py:494
   closure extensions.py:200
   runcommand dispatch.py:678

hg-git (at least the version i'm using) doesn't correctly implement this. The
result is that `hg rm` doesn't work properly.

Unfortunately, this is silent.

The comment clearly indicates that there should be a warning for 1, but the
abstract function doesn't warn the user that the subclass is broken -- it
should.

-- 
You are receiving this mail because:
You are on the CC list for the bug.