[PATCH 2 of 2] histedit: dropmissing hint

Augie Fackler raf at durin42.com
Mon Mar 14 22:27:15 EDT 2016


> On Mar 14, 2016, at 9:22 PM, Mateusz Kwapich <mitrandir at fb.com> wrote:
> 
> Your version provides a good explanation but I’d prefer something less verbose with
> ALL CAPS keyword so it’s easy to notice and read.
> 
> Also we don’t have repo object passed to that function so we can’t really check
> if obsolescence is on. Do you think we should pass it?
> 
> What do you think about something like that:
> 
> +        if obsolete.isenabled(repo, obsolete.createmarkersopt):
> +   dropverb = _('EXCLUDED')
> +        else:
> +   dropverb = _('DELETED')
> +
> +        hints.extend(("""'dropmissing' is enabled:
> +If you delete a changeset from the list it will be %s from rewritten history!
> +""" % dropverb).split('\n’))
> 

How about “discarded” in both cases?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160314/98ad9f30/attachment.sig>


More information about the Mercurial-devel mailing list