[PATCH 2 of 2] histedit: dropmissing hint

[timeless]

I favor "if you remove" / "it will be excluded"

Fwiw, the Mercurial localization style indeed isn't a big fan of partial
substitution as you flagged.

It definitely gives the localizer more flexibility to have the whole string.

(I've worked on projects which did use such substitutions, and usually it
wasn't a big deal, but then there were indeed cases when I was annoyed by
them...)
On Mar 15, 2016 7:49 AM, "Ryan McElroy" <rm at fb.com> wrote:

> On 3/15/2016 2:27 AM, Augie Fackler wrote:
>
>> On Mar 14, 2016, at 9:22 PM, Mateusz Kwapich <mitrandir at fb.com> wrote:
>>>
>>> Your version provides a good explanation but I’d prefer something less
>>> verbose with
>>> ALL CAPS keyword so it’s easy to notice and read.
>>>
>>> Also we don’t have repo object passed to that function so we can’t
>>> really check
>>> if obsolescence is on. Do you think we should pass it?
>>>
>>> What do you think about something like that:
>>>
>>> +        if obsolete.isenabled(repo, obsolete.createmarkersopt):
>>> +   dropverb = _('EXCLUDED')
>>> +        else:
>>> +   dropverb = _('DELETED')
>>> +
>>>
>>
> Unfortunately, I don't think translation works like this. Some languages
> change orders of things based on words used. Maybe I'm wrong in this case,
> but I think you need to translate the full string for both variants.
>
> +        hints.extend(("""'dropmissing' is enabled:
>>> +If you delete a changeset from the list it will be %s from rewritten
>>> history!
>>> +""" % dropverb).split('\n’))
>>>
>>
> I think we should either use the full config name (histedit.dropmissing)
> or not mention the config at all.
>
> Also, this line (in the resulting text editor) is pretty long. Maybe we
> should split it if we include the dropmissing bit.
>
>
>>> How about “discarded” in both cases?
>>
>
> DISCARDED, EXCLUDED, DELETED, EXPUNGED, OMITTED, FORGOTTEN, VANISHED,
> BLACKHOLED, DEVNULLED, MONGODB'D...
>
> I'm okay with any of them. What do you think about 'discarded', Mateusz?
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160315/94a3d115/attachment.html>