[PATCH 2 of 2 V2] dispatch: flush ui before returning from _runcatch

Yuya Nishihara yuya at tcha.org
Tue Mar 15 10:58:39 EDT 2016


On Mon, 14 Mar 2016 16:14:43 +0000, Jun Wu wrote:
> On 03/14/2016 03:09 PM, Yuya Nishihara wrote:
> > I guess this wouldn't catch the all cases. I'll recheck it tomorrow.
> 
> No, it wouldn't. Namely ParseError has "return -1" (which I think can be
> removed) and re-raise.
> 
> I didn't put it in "finally" because the inner try block has a "finally"
> already. I think it may be better to do "ui.flush()" only once.

I guess that ui.flush() would be necessary before entering to the debugger
session.

> Now I prefer adding a "finally" here.

Can you send new version? I think ui.flush() can be done at the finally block
of dispatch().


More information about the Mercurial-devel mailing list