[PATCH 3 of 3] extensions: also search for extension in the 'hgext3rd' package

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Mar 16 15:19:22 EDT 2016



On 03/14/2016 07:24 AM, Ryan McElroy wrote:
> On 3/14/2016 1:49 PM, Pierre-Yves David wrote:
>>
>>
>> On 03/14/2016 01:41 PM, timeless wrote:
>>> It isn't useful.
>>>
>>> If we want to have a --debug which lists the search path, that's fine.
>>>
>>> But for normal "did load" cases, we shouldn't show failures to find
>>> extensions in earlier parts of the path.
>>>
>>> When I run `echo hi` with a PATH of:
>>> /usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
>>>
>>> I don't get:
>>>   -bash: /usr/local/bin/echo: command not found
>>> hi
>>>
>>> I just get:
>>> hi
>>
>> That's perpendicular to my patch, there is already such output without
>> it.
>>
>
> Doesn't this patch make things strictly worse by adding another place to
> look?

Not sure worth apply. This provide with useful debug information and 
I've never heard a complain about them until someone spotted them in 
this patch. So I'm not eager to consider them as a bad things and even 
less a blocker since it seems fairly out of scope here.

Thoughs?

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list