[PATCH] tests: python executable path should always be globbed

Sean Farley sean at farley.io
Wed Mar 16 17:12:28 EDT 2016


Augie Fackler <raf at durin42.com> writes:

> On Tue, Mar 15, 2016 at 03:54:30PM -0700, danek.duvall at oracle.com wrote:
>> # HG changeset patch
>> # User Danek Duvall <danek.duvall at oracle.com>
>> # Date 1458082257 25200
>> #      Tue Mar 15 15:50:57 2016 -0700
>> # Node ID c54f92f246b1d0d353d9327afa8664d0275d30ec
>> # Parent  99c113c701ef57c5b3165f35071bbb5517372683
>> tests: python executable path should always be globbed
>>
>> Although this is coming in under the guise of consistency, part of the
>> desire for this is that at least as part of the official Solaris builds,
>> we build with a versioned python interpreter, such as "python2.7", which
>> doesn't match "*python".
>>
>> diff --git a/tests/test-install.t b/tests/test-install.t
>> --- a/tests/test-install.t
>> +++ b/tests/test-install.t
>> @@ -25,7 +25,7 @@ hg debuginstall JSON
>>      "extensionserror": null,
>>      "hgmodules": "*mercurial", (glob)
>>      "problems": 0,
>> -    "pythonexe": "*python", (glob)
>> +    "pythonexe": "*", (glob)
>
> This weirds me out just a little. Can I interest you in *py*? That
> would still match (say) python, python2.7, and pypy, but would at
> least fail to match ruby. Thoughts?
>
> (I might be too paranoid here.)

I also was a little paranoid but I recently used a few esoteric python
compilers / interpreters (pyston and nuitka come to mind) so I'm ok with
a generic glob for now.


More information about the Mercurial-devel mailing list