[PATCH 3 of 3 V2] chgserver: add a config option to preload repo

[Pierre-Yves David]

On 03/16/2016 03:59 PM, Jun Wu wrote:
> On 03/16/2016 08:12 PM, Pierre-Yves David wrote:
>> Isn't it a bit early to play with that ? I would advocate that we get
>> something running (pass all tests, including 3rd party of interrest to
>> you)
>> then introduce these option with some timing data.
>
> The patch is about a new direction. I do want feedback on this topic early.
> It won't change the current chg behavior by default.

Then it should live the 'experimental' section until we get a better 
idea of if this is useful or not.

>> Because right now, we suspect this would help but we seems to be lacking
>> performance number to back there usefulness.
>
> I have the number for a large fb repo. "preloadrepo = True" saves 40ms.

You should include them in the commit description then.

>> (also, please make a patch for each option)
>
> Do you mean I need 2 extra patches to do the space change?

Nevermind I got confused ny the skiphash movement and though you were 
adding it. Sorry about that

Cheers,

-- 
Pierre-Yves David