[PATCH] tests: python executable path should always be globbed

Augie Fackler raf at durin42.com
Wed Mar 16 19:20:07 EDT 2016


On Mar 16, 2016 5:09 PM, "Danek Duvall" <danek.duvall at oracle.com> wrote:
>
> Augie Fackler wrote:
>
> > On Tue, Mar 15, 2016 at 03:54:30PM -0700, danek.duvall at oracle.com wrote:
> > > # HG changeset patch
> > > # User Danek Duvall <danek.duvall at oracle.com>
> > > # Date 1458082257 25200
> > > #      Tue Mar 15 15:50:57 2016 -0700
> > > # Node ID c54f92f246b1d0d353d9327afa8664d0275d30ec
> > > # Parent  99c113c701ef57c5b3165f35071bbb5517372683
> > > tests: python executable path should always be globbed
> > >
> > > Although this is coming in under the guise of consistency, part of the
> > > desire for this is that at least as part of the official Solaris
builds,
> > > we build with a versioned python interpreter, such as "python2.7",
which
> > > doesn't match "*python".
> > >
> > > diff --git a/tests/test-install.t b/tests/test-install.t
> > > --- a/tests/test-install.t
> > > +++ b/tests/test-install.t
> > > @@ -25,7 +25,7 @@ hg debuginstall JSON
> > >      "extensionserror": null,
> > >      "hgmodules": "*mercurial", (glob)
> > >      "problems": 0,
> > > -    "pythonexe": "*python", (glob)
> > > +    "pythonexe": "*", (glob)
> >
> > This weirds me out just a little. Can I interest you in *py*? That
> > would still match (say) python, python2.7, and pypy, but would at
> > least fail to match ruby. Thoughts?
>
> Sure, that'd be fine with me, but then we probably ought to change all of
> them, right?  I just went for the smallest change here.

I'm convinced by Sean's message. I'll queue this once I'm able. Thanks!

>
> Danek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160316/5ac0f844/attachment.html>


More information about the Mercurial-devel mailing list