[PATCH 4 of 5] chgserver: add an explicit gc to trigger __del__

Yuya Nishihara yuya at tcha.org
Thu Mar 17 10:18:05 EDT 2016


On Tue, 15 Mar 2016 09:58:35 +0000, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark at fb.com>
> # Date 1457996883 0
> #      Mon Mar 14 23:08:03 2016 +0000
> # Node ID 1dcd622a1f8ffdbfedad1a284dc09c5ea409712d
> # Parent  c769f8196ccfdfa546862b0c4f608b78ca80a1c7
> chgserver: add an explicit gc to trigger __del__
> 
> SocketServer.ForkingMixIn uses os._exit which will skip all cleanup handlers.
> We want to run __del__ to make things like transactions work.
> This patch adds a "gc.collect()" to trigger __del__. It is helpful for chg
> to pass some test cases in test-devel-warnings.t.

I think these tests are incompatible with chg by nature because they rely
on gc. Perhaps we should disable them in chg.


More information about the Mercurial-devel mailing list