[PATCH 4 of 5] chgserver: add an explicit gc to trigger __del__

Yuya Nishihara yuya at tcha.org
Fri Mar 18 18:28:53 EDT 2016


On Fri, 18 Mar 2016 10:59:47 -0700, Jun Wu wrote:
> On 03/18/2016 07:54 AM, Yuya Nishihara wrote:
> > Well, I agree _exit() isn't normal, but tr.release() shouldn't rely on
> > exit(). Even without chg, you can do "runcommand buggylocking" more than
> > once in the same process.
> 
> I think they are 2 issues. First as chg, not calling __del__ will just surprise
> people. Transaction is not the only  __del__ user. There are some other places
> like {ssh,http}peer.py, atomictempfile, dirstateguard, etc. Thus this patch is
> necessary, as it's hard to touch SocketServer code to change os._exit.

I see. Queued this patch, thanks. I've updated the commit message to include
the other uses of __del__.


More information about the Mercurial-devel mailing list