[PATCH 2 of 2] largefiles: replace invocation of os.path module by vfs in lfutil.py
pierre-yves.david at ens-lyon.org
Fri Mar 18 22:12:47 EDT 2016
On 03/18/2016 07:04 PM, Pierre-Yves David wrote:
> On 03/14/2016 01:31 PM, liscju wrote:
>> # HG changeset patch
>> # User liscju <piotr.listkiewicz at gmail.com>
>> # Date 1457983222 -3600
>> # Mon Mar 14 20:20:22 2016 +0100
>> # Node ID 7d99ed52e3d5908a34e92d99094e613c3c30f050
>> # Parent a4715f03a6c7bdcaec1ef5a4a9c530c5911dfd02
>> largefiles: replace invocation of os.path module by vfs in lfutil.py
>> Replaces invocations os.path functions to methods in vfs. Unfortunately
>> (in my view) this makes code less readable, because instead of using
>> clear variable names with path it needs to replace them with vfs(..).
>> I need guidance how to make such transition look more readable.
>> For example in this patch there is example with few places with
>> wvfs.join(standindir), standindir before this patch was absolute
>> path, in this it is changed to relative because it is used also
>> in expression wvfs.join(standindir, pat).
> This looks "nince" but why are we doing all this?
I chatted with Sean, this is apparently gratuitous nice improvement,
Thanks. Pushed to the clowncopter, thanks.
More information about the Mercurial-devel