[PATCH 4 of 5] crecord: remove unimplemented review action

Pierre-Yves David pierre-yves.david at ens-lyon.org
Sat Mar 19 16:22:03 EDT 2016



On 03/19/2016 11:30 AM, Sean Farley wrote:
>
> Pierre-Yves David <pierre-yves.david at ens-lyon.org> writes:
>
>> On 03/19/2016 11:14 AM, Jordi GutiƩrrez Hermoso wrote:
>>> On Sat, 2016-03-19 at 09:54 -0700, Pierre-Yves David wrote:
>>>>
>>>> On 03/18/2016 12:46 PM, Jordi GutiƩrrez Hermoso wrote:
>>>>> On Fri, 2016-03-18 at 11:18 -0700, Ryan McElroy wrote:
>>>>>> # HG changeset patch
>>>>>> # User Ryan McElroy <rmcelroy at fb.com>
>>>>>> # Date 1458324363 25200
>>>>>> #      Fri Mar 18 11:06:03 2016 -0700
>>>>>> # Node ID e59c0deb368d99163912d379d4c7b87beb22f2a6
>>>>>> # Parent  d8070a9639933f2c37552f865288fb070cf816e8
>>>>>> crecord: remove unimplemented review action
>>>>>>
>>>>>> The review action is not implemented,
>>>>>
>>>>> It just wasn't copied over from crecord for some reason. I'm on it.
>>>>> It's not a big change, and it's useful: it allows you to edit the diff
>>>>> in an editor before actually applying it.
>>>>
>>>> don't we already have an 'edit' action in crecord for this purpose?
>>>
>>> Yes, but it's midly useful to still have one final chance to review
>>> and modify the whole patch at once instead of just individual hunks.
>>
>> Could we have a way to make 'edit' able to handle that ? so that we can
>> remove the "review" option?
>
> How would you make 'edit' (an action on a chunk) to handle editing the
> whole patch

It does not have to be at the chunk level, I cannot see theoritical 
issue with using "edit" at the file level. Then if we gain a "all patch" 
box in the UI, that would fit "review" role, right?

> at the end?

At the end does not seems to important here.

Did I missed something?

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list