[PATCH] chgserver: drop old hack to recreate ui on HGPLAIN change

[Yuya Nishihara]

# HG changeset patch
# User Yuya Nishihara <yuya at tcha.org>
# Date 1458495855 25200
#      Sun Mar 20 10:44:15 2016 -0700
# Node ID d48c308243acd89b97cb1dc056a0ae979c80a795
# Parent  0e7a929754aa4510e946dec8eba1cc79f9558361
chgserver: drop old hack to recreate ui on HGPLAIN change

It's been superseded by config/env hash. A log message is simplified as we no
longer need a diff of environment variables. Also, _loadnewui() is changed to
require args since it can't copy old --config values without args.

diff --git a/hgext/chgserver.py b/hgext/chgserver.py
--- a/hgext/chgserver.py
+++ b/hgext/chgserver.py
@@ -267,10 +267,7 @@ def _newchgui(srcui, csystem):
 
     return chgui(srcui)
 
-def _loadnewui(srcui, args=None):
-    if not args:
-        args = []
-
+def _loadnewui(srcui, args):
     newui = srcui.__class__()
     for a in ['fin', 'fout', 'ferr', 'environ']:
         setattr(newui, a, getattr(srcui, a))
@@ -524,18 +521,9 @@ class chgcmdserver(commandserver.server)
             newenv = dict(s.split('=', 1) for s in l)
         except ValueError:
             raise ValueError('unexpected value in setenv request')
-
-        diffkeys = set(k for k in set(os.environ.keys() + newenv.keys())
-                       if os.environ.get(k) != newenv.get(k))
-        _log('change env: %r\n' % sorted(diffkeys))
-
+        _log('setenv: %r\n' % sorted(newenv.keys()))
         os.environ.clear()
         os.environ.update(newenv)
-
-        if set(['HGPLAIN', 'HGPLAINEXCEPT']) & diffkeys:
-            # reload config so that ui.plain() takes effect
-            self.ui, _lui = _loadnewui(self.ui)
-
         _clearenvaliases(commands.table)
 
     capabilities = commandserver.server.capabilities.copy()