[remotefilelog] rfc: store refactor

Durham Goode durham at fb.com
Sun Mar 20 20:07:05 EDT 2016


This is mainly aimed at Augie, but the refactor I did to remotefilelog to make it adhere to the ContentStore / MetadataStore pattern can be found here: https://bitbucket.org/DurhamG/remotefilelog/commits/branch/newstore  (20 patches, 44d67fe through 14125f8).  It's mostly code reorganization, so it's not as scary to review as it looks (there's very little new logic).

There's a bunch of naming issues (basestore.contains() is a bad name; ioutil should be moved into shallowutil; etc), but I'll probably fix that stuff as follow up patches.  All the tests pass for every commit.

Augie, take a look if you get a chance.  Otherwise I'll get someone at FB to review it before I push it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160321/edeb0d9b/attachment.html>


More information about the Mercurial-devel mailing list