[PATCH 3 of 3] chgserver: print traceback if --traceback flag is passed to validate

Sean Farley sean at farley.io
Mon Mar 21 14:52:13 EDT 2016


Jun Wu <quark at fb.com> writes:

> On 03/20/2016 06:27 PM, Yuya Nishihara wrote:
>>           try:
>> -            self.ui, lui = _loadnewui(self.ui, args)
>> +            try:
>> +                self.ui, lui = _loadnewui(self.ui, args)
>
> The nested try catch is not necessary, since dispatch.py won't print traceback
> even with --traceback when it encounters ParseError.
>
> Other than that, the series look good to me.
>
> smf: My ui refactoring plan includes replacing "debugflag" etc. with @property
> and killing fixconfig(), which may make this cleaner. But the refactoring won't
> happen soon.

Ok, I see. This seems good to me, then.


More information about the Mercurial-devel mailing list