[PATCH 4 of 4 V2] resolve: wrap implementation in a ui.tempconfig context

Siddharth Agarwal sid at less-broken.com
Tue Mar 22 13:38:39 EDT 2016


On 3/22/16 10:36, Martin von Zweigbergk via Mercurial-devel wrote:
> I see. Follow-up questions: The methods in cmdutil are meant to be
> reusable, right?

Much of the time, though not always I think. There are a bunch of 
specialized functions in cmdutil.

>   Does it make sense to call your new cmdutil.resolve()
> without wrapping it in that "with ui.tempconfig()" thing?

Yeah -- in particular different callers might want to set different 
ui.forcemerge tools.

>   Maybe it
> does, I don't know. Just checking that this last patch doesn't make
> the interface worse in the name of less indentation.


More information about the Mercurial-devel mailing list