[PATCH evolve-ext] split: reuse the pre-split commit message for the split ones

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Mar 22 22:11:50 EDT 2016



On 03/22/2016 07:08 PM, Jordi Gutiérrez Hermoso wrote:
> On Tue, 2016-03-22 at 12:00 -0700, Pierre-Yves David wrote:
>>
>> On 03/20/2016 03:18 PM, Jordi Gutiérrez Hermoso wrote:
>>> # HG changeset patch
>>> # User Jordi Gutiérrez Hermoso <jordigh at octave.org>
>>> # Date 1458511862 14400
>>> #      Sun Mar 20 18:11:02 2016 -0400
>>> # Node ID f3c32a01d13f8bf64d29a758c6deb6dc8ee90466
>>> # Parent  9bcb24c3ba8d2b5a7082ae61ac2193e867234822
>>> split: reuse the pre-split commit message for the split ones
>>>
>>> The original commit message is probably relevant in some way for the
>>> split commit messages. It is helpful for the user to have access to
>>> the pre-split commit message, so we provide the original commit
>>> message. This is more helpful than completely dropping the original
>>> commit message during a split.
>>
>> I'm a bit confused here because I -already- see such behavior without
>> your patch.
>>
>> https://www.mercurial-scm.org/repo/evolve/file/9bcb24c3ba8d2b5a7082ae61ac2193e867234822/hgext/evolve.py#l2788
>>
>> However that aspect seems to be untested, it would be great to add a test.
>
> Huh, I think I wrote this patch when I was on an old head, then
> rebased, and didn't notice that the new base already had the
> functionality.
>
> I still prefer my wording, though. Can I resend that part?

Yep, submit your rewording to the crowd and we'll see what they think of it.

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list