[PATCH] graphmod: set default edge styles for ascii graphs

Sean Farley sean at farley.io
Wed Mar 23 14:37:29 EDT 2016


Pierre-Yves David <pierre-yves.david at ens-lyon.org> writes:

> On 03/23/2016 11:31 AM, Sean Farley wrote:
>>
>> Pierre-Yves David <pierre-yves.david at ens-lyon.org> writes:
>>
>>> On 03/23/2016 11:12 AM, Martijn Pieters wrote:
>>>> # HG changeset patch
>>>> # User Martijn Pieters <mjpieters at fb.com>
>>>> # Date 1458756767 25200
>>>> #      Wed Mar 23 11:12:47 2016 -0700
>>>> # Node ID 7c80b1e1f34cfee735e1876ddd2c9edb76aa4a46
>>>> # Parent  6fb1d3c936d2f80608963bdfcac1e75db2e69304
>>>> graphmod: set default edge styles for ascii graphs
>>>>
>>>> Leaving regular parent edges set to |, grandparent edges set to : and missing
>>>> parent edges set to end early. A sample graph:
>>>
>>> This seems a good start to me. But I've been a bit too involved into
>>> Martijn work to queue this UI change myself. Can another committer look
>>> at it?
>>>
>>> I think these default are a good improvement and that we should move
>>> forward with them. We still have a month of time to adjust them and
>>> taking that patch will increase their exposure and feedback we get from
>>> them.
>>
>> I've been playing with the new graph symbols for a day or so and it's
>> great. Though, I think this patch is a *bit* rushed. I mean, it hasn't
>> been marked as experimental or RFC yet. Did I miss something?
>
> My (personnal) approach on that would be:
> - We take the new default now,
> - We reevaluate before the freeze and back them out if we are not 
> confident.
>
> The last item is the important one. Backing that out is very much on the 
> table.
>
> (but getting confident kinda requires to get them out there)

That sounds fair to me.


More information about the Mercurial-devel mailing list