[PATCH] rebase: persist rebaseskipobsolete state

Laurent Charignon lcharignon at fb.com
Thu Mar 24 19:50:35 EDT 2016


Yes, but if we don't change the format, we could have rebase --continue
doing different things depending on what happens between the abort and
continue.
I think that we want rebase --continue to show the same things than rebase
would have showed if it hadn't aborted.
That goes against the way we do it for rebase normally and I don't feel
like it is the right choice here.
Does anyone else have an opinion on that?

Thanks,

Laurent

On 3/21/16, 11:57 AM, "Pierre-Yves David" <pierre-yves.david at ens-lyon.org>
wrote:

>
>
>On 03/21/2016 11:52 AM, Laurent Charignon wrote:
>> In theory we could recompute it, and maybe have a different result.
>
>What kind of different result and how would that be problematic?
>
>> I did store the information here because:
>> - it is simpler
>> - it is what we do for the other values during rebase (so we do the same
>> thing)
>>
>> What's the concern with writing / reading the list?
>
>Changing the format is not great and I would prefer that we don't have
>to do it.
>
>Cheers,
>
>-- 
>Pierre-Yves David



More information about the Mercurial-devel mailing list