[PATCH 2 of 2 v2] run-tests: loadtimes+savetimes should be limited to testdir TODO

Yuya Nishihara yuya at tcha.org
Sun Mar 27 12:08:07 EDT 2016


On Tue, 22 Mar 2016 00:05:43 -0500, timeless wrote:
> # HG changeset patch
> # User timeless <timeless at mozdev.org>
> # Date 1458599102 0
> #      Mon Mar 21 22:25:02 2016 +0000
> # Node ID 2681e13f2b72b391ea0516c84b17cec59c436451
> # Parent  432352f451d0eb4ece052ffebdf3c18b02cc89ec
> run-tests: loadtimes+savetimes should be limited to testdir TODO
> 
> This should be fixed by someone...

Looks like an unfinished patch, skipped.

> diff --git a/tests/run-tests.py b/tests/run-tests.py
> --- a/tests/run-tests.py
> +++ b/tests/run-tests.py
> @@ -1657,6 +1657,7 @@
>  # newest.
>  
>  def loadtimes(testdir):
> +    # This should only deal with times for tests in testdir
>      times = []
>      try:
>          with open(os.path.join(testdir, b'.testtimes-')) as fp:
> @@ -1669,6 +1670,7 @@
>      return times
>  
>  def savetimes(testdir, result):
> +    # This should only deal with times for tests in testdir
>      saved = dict(loadtimes(testdir))
>      maxruns = 5
>      skipped = set([str(t[0]) for t in result.skipped])
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list