[PATCH 2 of 2] tests: make run-tests.py invokes tests with needed variables only (issue5069)
pierre-yves.david at ens-lyon.org
Sun Mar 27 15:36:30 EDT 2016
On 03/26/2016 04:45 AM, liscju wrote:
> # HG changeset patch
> # User liscju <piotr.listkiewicz at gmail.com>
> # Date 1458986707 -3600
> # Sat Mar 26 11:05:07 2016 +0100
> # Node ID 19a08baae8794c77f4876161ea4bbe3f5cb6b6ff
> # Parent ffe9bc7aea5a63bc82e7322da9ff3448f13abaec
> tests: make run-tests.py invokes tests with needed variables only (issue5069)
> Before this patch tests were invoked with all environment variables
> except fixed set of known problematic environment variables. This
> commit makes run-tests.py pass to tests only that variables that
> are actually used in run-tests.py
> This commit is only proposal of solution. Class rememberusedkeyenv
> is not implementing all dictionary methods, only ones that are
> actually used in run-tests.py when accessing environment variables.
> Other possible solution would be to make a fixed list of used
> environment variables in run-tests.py.
> I am looking forward for suggestions how this should be implemented.
This magic object seems too magical to me. I would prefer to have an
explicit list of white listed environment variable.
Keep also in mind that the test runner is used by other third party
extension that may have there own need for environment variable. What is
the current story for them to expend this list? We should probably make
the run-tests.py test checks for this.
More information about the Mercurial-devel