[PATCH] bundle: move writebundle() from changegroup.py to bundle2.py (API)

Pierre-Yves David pierre-yves.david at ens-lyon.org
Mon Mar 28 22:20:44 EDT 2016



On 03/28/2016 02:58 PM, Martin von Zweigbergk via Mercurial-devel wrote:
> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz at google.com>
> # Date 1459201289 25200
> #      Mon Mar 28 14:41:29 2016 -0700
> # Node ID c8f4eed3af60ad0b33ff55fcfbe3cedf2d8760c1
> # Parent  5474dc73680f96e79ae3c255fb01b7943b2fc2d1
> bundle: move writebundle() from changegroup.py to bundle2.py (API)
>
> writebundle() writes a bundle2 bundle or a plain changegroup1. Imagine
> away the "2" in "bundle2.py" for a moment and this change should makes
> sense. The bundle wraps the changegroup, so it makes sense that it
> knows about it. Another sign that this is correct is that the delayed
> import of bundle2 in changegroup goes away.

Pushed to the clowncopter, thanks

> I'll leave it for another time to remove the "2" in "bundle2.py"
> (alternatively, extract a new bundle.py from it).

Creating a new 'bundle.py' seems like a good idea.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list