[PATCH 3 of 3] destutil: show messages at updating to the closed head as warning

FUJIWARA Katsunori foozy at lares.dti.ne.jp
Tue Mar 29 05:22:20 EDT 2016


At Sun, 27 Mar 2016 11:31:11 -0700,
Pierre-Yves David wrote:
> 
> On 03/25/2016 06:57 PM, FUJIWARA Katsunori wrote:
> > # HG changeset patch
> > # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> > # Date 1458957211 -32400
> > #      Sat Mar 26 10:53:31 2016 +0900
> > # Node ID 4d090f9af6a2d7d238fb7f5ef38601f089e7a2a2
> > # Parent  38fff615b9baa28152cc346e90b5cc2927aae7ec
> > destutil: show messages at updating to the closed head as warning
> >
> > diff --git a/mercurial/destutil.py b/mercurial/destutil.py
> > --- a/mercurial/destutil.py
> > +++ b/mercurial/destutil.py
> > @@ -397,7 +397,7 @@ def _statusotherbranchheads(ui, repo):
> >           #  ========= ==========
> >           otherheads = repo.revs('%ln - parents()', heads)
> >           if repo['.'].closesbranch():
> > -            ui.status(_('no open descendant branch heads, '
> > +            ui.warn(_('warning: no open descendant branch heads, '
> >                           'updating to a closed head\n'
> >                           '(committing will reopen the branch)\n'))
> 
> I like the move to 'ui.warn' but I'm not sure we want the 'warning:' 
> prefix. We rarely use it and it usually for various error. Can we get a 
> version of this patch without that prefix?

OK, I'll send revised ones.

> Cheers,
> 
> -- 
> Pierre-Yves David
> 

----------------------------------------------------------------------
[FUJIWARA Katsunori]                             foozy at lares.dti.ne.jp


More information about the Mercurial-devel mailing list