[PATCH 3 of 3 RFC] import: add new --faithful flag to use metadata but relax checks

Kevin Bullock kbullock+mercurial at ringworld.org
Tue Mar 29 10:33:29 EDT 2016


> On Mar 29, 2016, at 09:29, Augie Fackler <raf at durin42.com> wrote:
> 
>> On Mar 29, 2016, at 9:23 AM, Kevin Bullock <kbullock+mercurial at ringworld.org> wrote:
>> 
>> It seems like we have three classes of metadata here:
>> 
>> 1. user, date, description, branch name - always imported, no problems here
>> 2. node id + original parent (others?) - can be used as hints in importing
>> 3. extra data that is part of the commit hash but not the patch - causes problems with --exact
>> 
>> For the sake of completeness, though it's probably a bad idea: Would it be reasonable to make --exact behave like your new flag instead? When --exact first appeared there were fewer things that wrote into extra, thus fewer ways that an export could fail to exactly represent a commit. (transplant_source notably dates from before import --exact.)
> 
> Exact does what it says on the tin, preventing data loss. In a world where diff still can’t completely represent our changesets (eg mode changes without --git), exact’s semantics are actually valuable to some users (see also [0]). Fixing extra transmission would likely be a better approach than this flag, but that’s hard and this is easy.
> 
> 0: https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-February/080245.html <https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-February/080245.html>

Like I said, probably a bad idea. Thanks for linking to the context I had missed.

I'm in favor of --useparents. Maybe --usemeta, but that's less direct. What I'm trying to work out is whether "parents" is close enough to including all of class (2) of metadata.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160329/b2634786/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160329/b2634786/attachment.sig>


More information about the Mercurial-devel mailing list