[PATCH v3] tests: fix builtin module test on pypy

Yuya Nishihara yuya at tcha.org
Thu Mar 31 08:50:53 EDT 2016


On Wed, 30 Mar 2016 21:54:43 +0200, Maciej Fijalkowski wrote:
> # HG changeset patch
> # User Maciej Fijalkowski <fijall at gmail.com>
> # Date 1459367666 -7200
> #      Wed Mar 30 21:54:26 2016 +0200
> # Node ID 84be092f00583806823976cd1334730d89936223
> # Parent  ff0d3b6b287f89594bd8d0308fe2810d2a18ea01
> tests: fix builtin module test on pypy
> 
> On pypy datetime and cProfile are modules written in Python, not in C.
> For the purpose of this test, just list them explicitely as builtins,
> which silences warnings about them being imported before stdlib modules.
> 
> diff -r ff0d3b6b287f -r 84be092f0058 contrib/import-checker.py
> --- a/contrib/import-checker.py	Tue Mar 29 12:29:00 2016 -0500
> +++ b/contrib/import-checker.py	Wed Mar 30 21:54:26 2016 +0200
> @@ -182,6 +182,8 @@
>      yield 'builtins' # python3 only
>      for m in 'fcntl', 'grp', 'pwd', 'termios':  # Unix only
>          yield m
> +    for m in 'cPickle', 'datetime': # in Python (not C) on PyPy
> +        yield m

It shouldn't be matter whether the module is written in C or Python.
I suspect that the lib_pypy directory isn't looked up.


More information about the Mercurial-devel mailing list