[PATCH 4 of 4] revset: make _parsealiasdecl() simply return the original parsed tree

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Mar 31 23:46:07 EDT 2016



On 03/30/2016 08:38 AM, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1456735566 -32400
> #      Mon Feb 29 17:46:06 2016 +0900
> # Node ID 744b168050832926b97dfefe486d6f33bcc7d8b2
> # Parent  ab9445ee0dbe55f4258645e065f7121df2c6f83a
> revset: make _parsealiasdecl() simply return the original parsed tree

I've taken this.

Dropping all this checks is a bit scary, but no test complains so I 
guess we can trust the parser. inlining all this functions are a bit sad 
as this make the code less readable.
However unifying these two code paths seems a noble goal as this will 
reduce code duplication and help maintainance and evolution.

Cheers

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list