[PATCH v2] rollback: add a config knob for entirely disabling the command

Augie Fackler raf at durin42.com
Wed May 4 10:55:59 EDT 2016


> On May 4, 2016, at 9:56 AM, Kevin Bullock <kbullock+mercurial at ringworld.org> wrote:
> 
>> On May 4, 2016, at 01:02, Gregory Szorc <gregory.szorc at gmail.com> wrote:
>> 
>> 'hg rollback' is already marked as deprecated. Can we rename it (debugrollback?), remove it entirely, require a config option to enable it, or move it to an extension?
> 
> Remember that "deprecated" in Mercurial doesn't mean "slated for removal", it means "not recommended or supported but will continue to work as it did". I think having a knob to disable it is the best we can do.

*nod* - I’m hoping to make good progress on a roll-up knob for some fit-and-finish changes like this soon, so hopefully we can have one opt-in “Break me if it means fixing a past mistake” config knob.

> 
> Patch LGTM.

Sigh, I just noticed a test failure, so I’ll send a v3.

> 
> pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
> Kevin R. Bullock
> 
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160504/0571822f/attachment.sig>


More information about the Mercurial-devel mailing list