[PATCH v2] rollback: add a config knob for entirely disabling the command

[Sean Farley]

Gregory Szorc <gregory.szorc at gmail.com> writes:

> On May 4, 2016, at 06:56, Kevin Bullock <kbullock+mercurial at ringworld.org> wrote:
>
>>> On May 4, 2016, at 01:02, Gregory Szorc <gregory.szorc at gmail.com> wrote:
>>> 
>>> 'hg rollback' is already marked as deprecated. Can we rename it (debugrollback?), remove it entirely, require a config option to enable it, or move it to an extension?
>> 
>> Remember that "deprecated" in Mercurial doesn't mean "slated for removal", it means "not recommended or supported but will continue to work as it did". I think having a knob to disable it is the best we can do.
>
> I know. It's just that this command is a massive footgun that when fired can lead to permanent data loss. That violates a core principle of VCS tools: don't lose my data. I feel that's a bigger concern than BC.

Yeah, I agree with Greg here. We have the (BC) flag for things that are
really bad like this. We've even done it before in the past with 'strip
-b' (a flag that was confused for '--branch' but actually meant 'do not
create a backup file).