[PATCH 3 of 3] revset: define _parsealias() in _aliasrules class

Sean Farley sean at farley.io
Wed May 4 19:10:26 EDT 2016


Yuya Nishihara <yuya at tcha.org> writes:

> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1460866004 -32400
> #      Sun Apr 17 13:06:44 2016 +0900
> # Node ID e5d489376621dff13f1d72f0d8efe2f5385da400
> # Parent  478eb6b0fcd9b91fdc34d9ee763ad093bc1a06e7
> revset: define _parsealias() in _aliasrules class
>
> It's short. It doesn't make sense to define _parsealias() outside of the
> class.

These look fine to me at first glance.


More information about the Mercurial-devel mailing list