[PATCH 2 of 2] chgserver: add [alias] to confighash

Jun Wu quark at fb.com
Sat May 7 10:18:26 EDT 2016


# HG changeset patch
# User Jun Wu <quark at fb.com>
# Date 1462629092 -3600
#      Sat May 07 14:51:32 2016 +0100
# Node ID 3863d4110df0d196b352d894efc5030f9df0c887
# Parent  e4e2efae9f13369bd9e9691edd48a7da6fd18fcb
chgserver: add [alias] to confighash

The [alias] config section affects a global state: commands.table. It's hard
to trace whether an alias is added by a config option or an extension, and
add/remove aliases in a safe way per chg request. It will hurt performance a
bit if we clean the table and parse aliases every time. Therefore let's just
add it to confighash.

This will make chg pass test-pager.t.

diff --git a/hgext/chgserver.py b/hgext/chgserver.py
--- a/hgext/chgserver.py
+++ b/hgext/chgserver.py
@@ -80,6 +80,7 @@
 
 # sensitive config sections affecting confighash
 _configsections = [
+    'alias',  # affects global state commands.table
     'extdiff',  # uisetup will register new commands
     'extensions',
 ]


More information about the Mercurial-devel mailing list