[PATCH 1 of 4] devel: officially deprecate old style revset

Sean Farley sean at farley.io
Sun May 8 17:37:38 EDT 2016


Pierre-Yves David <pierre-yves.david at ens-lyon.org> writes:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> # Date 1462469010 -7200
> #      Thu May 05 19:23:30 2016 +0200
> # Node ID 70e701b45e36638fceffbb68d334b4f2478ecb76
> # Parent  3fd94f603190e50690e654fc211ba9801ff2c457
> # EXP-Topic deprecate
> devel: officially deprecate old style revset
>
> When we introduce the develwarning, we did not had an official deprecation API
> and infrastructure. We can now officially deprecate the old way with a version
> deadline.
>
> diff -r 3fd94f603190 -r 70e701b45e36 mercurial/revset.py
> --- a/mercurial/revset.py	Sun May 08 10:43:41 2016 +0200
> +++ b/mercurial/revset.py	Thu May 05 19:23:30 2016 +0200
> @@ -333,9 +333,9 @@ def getset(repo, subset, x):
>      # else case should not happen, because all non-func are internal,
>      # ignoring for now.
>      if x[0] == 'func' and x[1][0] == 'symbol' and x[1][1] in symbols:
> -        repo.ui.develwarn('revset "%s" use list instead of smartset, '
> -                          '(upgrade your code)' % x[1][1],
> -                          config='old-revset')
> +        repo.ui.deprecwarn('revset "%s" use list instead of smartset'

If I read this correctly, I think this should be 'revset "%s" uses a
list insted of a smartset'.


More information about the Mercurial-devel mailing list