[PATCH v4] rollback: add a config knob for entirely disabling the command

[Pierre-Yves David]

On 05/06/2016 06:22 AM, Kevin Bullock wrote:
>> On May 4, 2016, at 22:42, Augie Fackler <raf at durin42.com> wrote:
>>
>> # HG changeset patch
>> # User Augie Fackler <augie at google.com>
>> # Date 1462307605 14400
>> #      Tue May 03 16:33:25 2016 -0400
>> # Node ID 62ae5d974b76b3e61749fe89f11ae3bb176f487b
>> # Parent  906a1c8a75fd8a18e43e8545eedcbe5222f84647
>> rollback: add a config knob for entirely disabling the command
> Probably should've been done years ago. Pushed to -committed!

Hooray for having the flag.

While keeping in mind than "deprecated" does not mean "flagged for 
removal" it might still be a good idea to eventually disable 'hg 
rollback'. As Greg pointed, it can lead to unrecoverable data loss and 
as Sean pointed out, we did it in the past for small thing like 'hg 
strip -b'. An extra element to take in account is that the actual result 
of 'hg rollback' have been shifting a lot in the past years as more and 
more things are using transaction. So scripting using 'hg rollback' 
might have already broke multiple times (especially if they do a lot of 
local operation, pull should be fine, push is not).

I'm not saying we should do it, but I think there might be some room to 
think about it if someone is willing to make a full analysis.

In all case, getting this flag was a necessary first step.

-- 
Pierre-Yves David