[PATCH STABLE] deprecation: gate deprecation warning behind devel configuration

Gregory Szorc gregory.szorc at gmail.com
Thu May 12 22:12:02 EDT 2016



> On May 12, 2016, at 15:54, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
> 
> 
> 
>> On 05/05/2016 10:04 PM, Matt Mackall wrote:
>>> On Thu, 2016-05-05 at 16:36 +0200, Pierre-Yves David wrote:
>>> # HG changeset patch
>>> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
>>> # Date 1462458571 -7200
>>> #      Thu May 05 16:29:31 2016 +0200
>>> # Branch stable
>>> # Node ID 332d908d7b8a07ed3885fef9ffcc95ac99597e5f
>>> # Parent  61463b8fcef871ff3efff53945df4671c71c4e31
>>> # EXP-Topic deprecwarn
>>> deprecation: gate deprecation warning behind devel configuration
>>> 
>>> Regular users are not supposed to be exposed to the API deprecation warnings.
>>> 
>>> We now only issue them when the developper warnings are enabled.
>> Queued for stable with much cursing.
> 
> Unfortunately, the issue is even more problematic that first though.
> 
> At extension setup time the MQ extension is iterating over -all- commands to add them a --mq flag, checking the 'norepo' attribute in the process. This trigger the warning for all commands using the old style, creating, for some users, a wall of warning for each mercurial invocation.
> 
> With this changeset, the issue is fixed on the stable branch, but 3.8.1 does not have it. I believe we should release a 3.8.2 with this fix quickly before users impact is too problematic.

I support an out of cycle bug fix release. A number of Mozillians have complained about  seeing these messages.


More information about the Mercurial-devel mailing list