Build errors on xenial launchpad buildbots

[FUJIWARA Katsunori]

At Wed, 18 May 2016 12:46:42 -0700,
Sean Farley wrote:
> 
> It seems after 9d38a2061fd8 (patch: show lower-ed translated message
> correctly) I'm getting the following error below. I don't know the
> launchpad builders so any help here is appreciated!
> 
> 
> cd tests && python run-tests.py -j4
> sss...s.....ss..ss.s..sss.s..s...s........s.ss
> --- /«BUILDDIR»/mercurial-3.8.2+121-xenial/tests/test-commit-interactive.t
> +++ /«BUILDDIR»/mercurial-3.8.2+121-xenial/tests/test-commit-interactive.t.err
> @@ -899,7 +899,7 @@
>    > ?
>    > q
>    > EOF
> -  y - \x82\xb1\x82\xcc\x95\xcf\x8dX\x82\xf0\x8bL\x98^(yes) (esc)
> +  Binary file (standard input) matches
>  
>    $ LANGUAGE=
>  #endif
> 
> ERROR: test-commit-interactive.t output changed
> 

It seems a message of "grep" command, which is used to pick up help
line for "yes" command. It might be locale sensitive (run-tests.py
explicitly sets LC_ALL and LANG to C).

Could you confirm the patch below on launchpad buildbot environment ?

========================================
diff --git a/tests/test-commit-interactive.t b/tests/test-commit-interactive.t
--- a/tests/test-commit-interactive.t
+++ b/tests/test-commit-interactive.t
@@ -894,6 +894,8 @@ This tests that translated help message

   $ LANGUAGE=ja
   $ export LANGUAGE
+  $ LC_ALL=ja_JP.cp932
+  $ export LC_ALL

   $ hg commit -i --encoding cp932 2>&1 <<EOF | grep '^y - '
   > ?
@@ -901,7 +903,8 @@ This tests that translated help message
   > EOF
   y - \x82\xb1\x82\xcc\x95\xcf\x8dX\x82\xf0\x8bL\x98^(yes) (esc)

-  $ LANGUAGE=
+  $ LANGUAGE=C
+  $ LC_ALL=C
 #endif

 Skip
========================================

BTW, what OS/distribution/version is used on launchpad buildbot
environment ?

----------------------------------------------------------------------
[FUJIWARA Katsunori]                             foozy at lares.dti.ne.jp