Build errors on xenial launchpad buildbots

[FUJIWARA Katsunori]

At Thu, 19 May 2016 23:37:34 +0900,
Yuya Nishihara wrote:
> 
> On Thu, 19 May 2016 15:34:35 +0900, FUJIWARA Katsunori wrote:
> > At Wed, 18 May 2016 12:46:42 -0700,
> > Sean Farley wrote:
> > > 
> > > It seems after 9d38a2061fd8 (patch: show lower-ed translated message
> > > correctly) I'm getting the following error below. I don't know the
> > > launchpad builders so any help here is appreciated!
> > > 
> > > 
> > > cd tests && python run-tests.py -j4
> > > sss...s.....ss..ss.s..sss.s..s...s........s.ss
> > > --- /«BUILDDIR»/mercurial-3.8.2+121-xenial/tests/test-commit-interactive.t
> > > +++ /«BUILDDIR»/mercurial-3.8.2+121-xenial/tests/test-commit-interactive.t.err
> > > @@ -899,7 +899,7 @@  
> > >    > ?
> > >    > q
> > >    > EOF  
> > > -  y - \x82\xb1\x82\xcc\x95\xcf\x8dX\x82\xf0\x8bL\x98^(yes) (esc)
> > > +  Binary file (standard input) matches
> > >  
> > >    $ LANGUAGE=
> > >  #endif
> > > 
> > > ERROR: test-commit-interactive.t output changed
> > >   
> > 
> > It seems a message of "grep" command, which is used to pick up help
> > line for "yes" command. It might be locale sensitive (run-tests.py
> > explicitly sets LC_ALL and LANG to C).
> 
> FYI, recent versions of GNU grep assume files are encoded in LC_CTYPE, which
> is really annoying.
> 
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19230
> 
> And the encoding bits should be disabled by switching to C locale as C locale
> should be neutral, but GNU grep v2.24 had a bug, which is unfortunately shipped
> with Ubuntu xenial.
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800670
> http://packages.ubuntu.com/xenial/grep

Thank you for detailed information !

I got actual Ubuntu xenial (16.04) environment, and confirmed this
annoying grep v2.24 behavior on it :-<

I'll send patch soon !

----------------------------------------------------------------------
[FUJIWARA Katsunori]                             foozy at lares.dti.ne.jp