[PATCH 3 of 3 V2] revsets: add new toposort predicate

Pierre-Yves David pierre-yves.david at ens-lyon.org
Sun May 22 17:06:40 EDT 2016

On 05/20/2016 07:45 PM, Martijn Pieters wrote:
> On 19 May 2016 at 01:29, Pierre-Yves David
> <pierre-yves.david at ens-lyon.org> wrote:
>>>> Could we move the code around in an independant patch this would make
>>>> actual new code introduction and change easier to track.
>>> I adapted your code slightly to fit a predicate. I'm not sure that the
>>> move from graphmod.py to revset.py makes any sense without the
>>> changes.
>> I think that would significantly improve the reviewability of this
>> series of the move and the change were splitted. I am fine with a
>> changeset moving the function elsewhere even if the code is still only
>> called in the graphmod module. Can you give it a try?
> Shall I send a V2 with toposort() still a separate predicate? I have
> the split sorted for you.

At that point I think merging it with 'sort()' is the way to go we have
everyting in place, it make more sense and it is easier to discover
instead of being "yet another predicate". What is your opinion?

Pierre-Yves David

More information about the Mercurial-devel mailing list